Skip to content

fix(detectors): Ensure metric Detector deletion cleans up the AlertRule#112425

Merged
kcons merged 1 commit intomasterfrom
kcons/fulldel
Apr 7, 2026
Merged

fix(detectors): Ensure metric Detector deletion cleans up the AlertRule#112425
kcons merged 1 commit intomasterfrom
kcons/fulldel

Conversation

@kcons
Copy link
Copy Markdown
Member

@kcons kcons commented Apr 7, 2026

We don't really dual-write both ways, but we don't want to leave behind the AlertRule when we delete a metric Detector.

Fixes ISWF-2389.

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 7, 2026

@kcons kcons requested review from a team as code owners April 7, 2026 22:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kcons kcons enabled auto-merge (squash) April 7, 2026 23:23
@kcons kcons merged commit ce0da12 into master Apr 7, 2026
57 checks passed
@kcons kcons deleted the kcons/fulldel branch April 7, 2026 23:33
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…le (#112425)

We don't really dual-write both ways, but we don't want to leave behind
the AlertRule when we delete a metric Detector.


Fixes ISWF-2389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants